christinefeng commented on a change in pull request #749: PHOENIX-4521: Allow 
Pherf scenario to define per query max allowed query execution duration after 
which thread is interrupted
URL: https://github.com/apache/phoenix/pull/749#discussion_r402666262
 
 

 ##########
 File path: 
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/file/Header.java
 ##########
 @@ -24,8 +24,8 @@
             
"START_TIME,QUERY_GROUP,QUERY,TENANT_ID,AVG_MAX_TIME_MS,AVG_TIME_MS,AVG_MIN_TIME_MS,RUN_COUNT,EXPLAIN_PLAN,RESULT_ROW_COUNT"),
     DETAILED_BASE(
             
"BASE_TABLE_NAME,SCENARIO_NAME,ZOOKEEPER,ROW_COUNT,EXECUTION_COUNT,EXECUTION_TYPE,PHOENIX_PROPERTIES"
-                    + 
",START_TIME,QUERY_GROUP,QUERY,TENANT_ID,THREAD_NUMBER,CONCURRENCY_LEVEL"),
 
 Review comment:
   Adding query_id to the header just makes sure the query_id field gets 
written to the csv results file which helps with testing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to