christinefeng commented on a change in pull request #749: PHOENIX-4521: Allow
Pherf scenario to define per query max allowed query execution duration after
which thread is interrupted
URL: https://github.com/apache/phoenix/pull/749#discussion_r402672503
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java
##########
@@ -131,14 +142,16 @@ private void timedQuery() throws Exception {
Long start = EnvironmentEdgeManager.currentTimeMillis();
Date startDate = Calendar.getInstance().getTime();
String exception = null;
- long resultRowCount = 0;
+ Long resultRowCount = 0L;
+ String queryIteration = threadName + ":" + iterationNumber;
+ Boolean timedOut = false;
try {
conn = pUtil.getConnection(query.getTenantId(),
scenario.getPhoenixProperties());
conn.setAutoCommit(true);
final String statementString =
query.getDynamicStatement(ruleApplier, scenario);
statement = conn.prepareStatement(statementString);
- LOGGER.info("Executing: " + statementString);
+ LOGGER.info("Executing " + queryIteration + ": " +
statementString);
Review comment:
I added it because I feel like it's useful to know which execution of the
query we're on so you know how many were completed before a potential failure,
but you can also see that in the output files, so I can remove it if it's not
necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
