swaroopak commented on a change in pull request #769:
URL: https://github.com/apache/phoenix/pull/769#discussion_r413428999
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/index/IndexUpgradeToolTest.java
##########
@@ -125,6 +125,30 @@ public void testIfOptionsArePassedToIndexTool() {
it.populateIndexToolAttributes(commandLine);
}
+ @Test
Review comment:
If you prefer to have a new test for this, please consider removing
duplicate code in a function that can be called from both tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
