abhishek-chouhan commented on a change in pull request #769:
URL: https://github.com/apache/phoenix/pull/769#discussion_r413516427
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/index/IndexUpgradeToolTest.java
##########
@@ -125,6 +125,30 @@ public void testIfOptionsArePassedToIndexTool() {
it.populateIndexToolAttributes(commandLine);
}
+ @Test
Review comment:
The test is to ensure that we can override the properties through
IndexUpgradeTool too and that the properties are passed correctly to IndexTool
and can be parsed there. I've taken out the index tool parsing part which was
common with already written tests in the updated patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
