swaroopak commented on a change in pull request #769:
URL: https://github.com/apache/phoenix/pull/769#discussion_r413430362
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
##########
@@ -667,6 +676,7 @@ public int run(String[] args) throws Exception {
}
populateIndexToolAttributes(cmdLine);
Configuration configuration = getConfiguration(tenantId);
+ decorateConfWithProperties(configuration, cmdLine);
Review comment:
Instead of calling this function here, why not do it inside the 678 to
follow the setup code in the tool? You can extract properties in the function
call at line no. 677 and use/pass in at 678.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
