richardantal commented on a change in pull request #21:
URL: https://github.com/apache/phoenix-connectors/pull/21#discussion_r457223134
##########
File path: pom.xml
##########
@@ -60,6 +61,8 @@
<test.output.tofile>true</test.output.tofile>
<top.dir>${project.basedir}</top.dir>
+ <jdk.version>1.7</jdk.version>
Review comment:
There are significant changes in the java code between phoenix-hive and
phoenix-hive, it is not just a copy and pom.xml change.
Hive 3.x supports Hadoop 3 but hive 2 does not, Hive3 is intended to be used
with Phoenix 5 meanwhile the old phoenix-hive connector is working with phoenix
4.
This JDK version is in connectors pom.xml, all the modules but the
phoenix-hive3 uses jdk 1.7. In phoenix-hive3 it is being overwritten to 1.8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
