stoty commented on pull request #21: URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-662271718
> > Maybe pre-emptively move this code to org.apache.phoenix.hive3 package now, so that we don't have to deal with the 2.x vs 3.x conflicts later ? > > That's a really smart idea. Hive's classpath gets the entire world, most of the time. I've slept on (literally), and now I think that that's not the way to, as this package name is exposed to the Hive user-facing API, and having to deal with version specific package names would be an unnecessary inconvenience for the users. We should just have have something like phoenix-hbase-common, where we make the version-dependent classes abstract, and build the Hive2 and Hive3 connectors on top of it. This is of course just a plan for the future connector for 4.x, not for the present patch. > You have my +1 if you want to merge this one now, Istvan, but I respect the decision to clean up dependencies right away. Thank you. I'd like to get the code in ASAP, and deal with the dependencies and possible shaded JAR later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
