joshelser commented on pull request #21: URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-662162633
Rerunning tests worked this time. Not sure why they failed the first time. > I think that this needs a thorough review of the dependency handling. We are dependencyManaging some versions that we shouldn't, and there are dependencies and exclusions that I think are not needed. Do you think we should do this now, @stoty? I am OK to defer dependency cleanup to having a "good" state of this branch with hive3, and then try to make incremental changes to reduce subsequent "dependency cleanup" patches. You have my +1 if you want to merge this one now, Istvan, but I respect the decision to clean up dependencies right away. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
