stoty commented on pull request #21: URL: https://github.com/apache/phoenix-connectors/pull/21#issuecomment-666206745
Some minor issues: - Hive-exec dependency is duplicated - Pom indentation (since it's technically a new POM, you may want to have your IDE reformat it) - You may want to rename the hive version property to hive3.version, as it is distinct from the other hive connector's hive version - Netty dependency is in the test section, but not marked as test scope (probably just add test scope) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
