ntshmah commented on a change in pull request #924:
URL: https://github.com/apache/phoenix/pull/924#discussion_r506773763
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/DecimalAddExpression.java
##########
@@ -74,7 +74,7 @@ public boolean evaluate(Tuple tuple, ImmutableBytesWritable
ptr) {
result = NumberUtil.setDecimalWidthAndScale(result, maxLength,
scale);
}
if (result == null) {
- throw new DataExceedsCapacityException(PDecimal.INSTANCE,
maxLength, scale);
+ throw new DataExceedsCapacityException("", maxLength);
Review comment:
The type information could be useful here, and below too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
