ntshmah commented on a change in pull request #924:
URL: https://github.com/apache/phoenix/pull/924#discussion_r507907536



##########
File path: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectIT.java
##########
@@ -1677,6 +1677,8 @@ private void testUpsertSelectWithMultiByteChars(boolean 
autoCommit) throws Excep
             fail();
         } catch (SQLException e) {
             
assertEquals(SQLExceptionCode.DATA_EXCEEDS_MAX_CAPACITY.getErrorCode(), 
e.getErrorCode());
+            assertFalse(e.getMessage().contains("澴粖蟤य褻酃岤豦팑薰鄩脼ժ끦碉碉碉碉碉碉碉"));
+            assertTrue(e.getMessage().contains(String.valueOf(20)));

Review comment:
       nit: You could check for `VARCHAR(20)` instead of just `20`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to