ntshmah commented on a change in pull request #924:
URL: https://github.com/apache/phoenix/pull/924#discussion_r507911659
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/schema/MutationTest.java
##########
@@ -92,18 +92,24 @@ public void testSizeConstraint() throws Exception {
fail();
} catch (SQLException e) {
assertEquals(SQLExceptionCode.DATA_EXCEEDS_MAX_CAPACITY.getErrorCode(),e.getErrorCode());
+ assertFalse(e.getMessage().contains("abcd"));
+
assertTrue(e.getMessage().contains(String.valueOf(maxLength1)));
Review comment:
nit: Same here. Could include the datatype too in the exception message
and not just the length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
