yanxinyi commented on a change in pull request #1064:
URL: https://github.com/apache/phoenix/pull/1064#discussion_r552450031
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java
##########
@@ -148,21 +160,23 @@ public PhoenixDriver() { // for Squirrel
}
private Cache<ConnectionInfo, ConnectionQueryServices>
initializeConnectionCache() {
- Configuration config =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ Configuration config = HBaseFactoryProvider.getConfigurationFactory()
+ .getConfiguration();
int maxCacheDuration =
config.getInt(QueryServices.CLIENT_CONNECTION_CACHE_MAX_DURATION_MILLISECONDS,
QueryServicesOptions.DEFAULT_CLIENT_CONNECTION_CACHE_MAX_DURATION);
RemovalListener<ConnectionInfo, ConnectionQueryServices>
cacheRemovalListener =
new RemovalListener<ConnectionInfo, ConnectionQueryServices>() {
@Override
public void onRemoval(RemovalNotification<ConnectionInfo,
ConnectionQueryServices> notification) {
String connInfoIdentifier =
notification.getKey().toString();
- LOGGER.debug("Expiring " + connInfoIdentifier + " because
of "
- + notification.getCause().name());
+ if (LOGGER.isDebugEnabled()) {
Review comment:
Do we need if check here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
