yanxinyi commented on a change in pull request #1064:
URL: https://github.com/apache/phoenix/pull/1064#discussion_r552451886
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -184,22 +184,22 @@
public abstract class BaseTest {
public static final String DRIVER_CLASS_NAME_ATTRIB =
"phoenix.driver.class.name";
private static final double ZERO = 1e-9;
- private static final Map<String,String> tableDDLMap;
+ private static final Map<String, String> tableDDLMap;
private static final Logger LOGGER =
LoggerFactory.getLogger(BaseTest.class);
@ClassRule
public static TemporaryFolder tmpFolder = new TemporaryFolder();
- private static final int dropTableTimeout = 300; // 5 mins should be long
enough.
- private static final ThreadFactory factory = new
ThreadFactoryBuilder().setDaemon(true)
+ private static final int DROP_TABLE_TIMEOUT = 300; // 5 mins should be
long enough.
Review comment:
Nice coding style changing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
