wangchao316 commented on a change in pull request #1064:
URL: https://github.com/apache/phoenix/pull/1064#discussion_r552455806
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixEmbeddedDriver.java
##########
@@ -91,8 +89,15 @@
protected ReadOnlyProps getDefaultProps() {
return DEFAULT_PROPS;
}
-
- abstract public QueryServices getQueryServices() throws SQLException;
+
+ /**
+ * get query services
+ * @param info properties info
+ * @return query services
+ * @throws SQLException if failed to get query service.
+ */
+ public abstract QueryServices getQueryServices(Properties info)
Review comment:
> I see. You made an interface changes. I would suggest keep the
original method with depreciation tag and remove it after two release.
thanks , this is a good idea, I will do..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
