[
https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259521#comment-17259521
]
ASF GitHub Bot commented on PHOENIX-6050:
-----------------------------------------
wangchao316 commented on a change in pull request #1064:
URL: https://github.com/apache/phoenix/pull/1064#discussion_r552451847
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java
##########
@@ -148,21 +160,23 @@ public PhoenixDriver() { // for Squirrel
}
private Cache<ConnectionInfo, ConnectionQueryServices>
initializeConnectionCache() {
- Configuration config =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ Configuration config = HBaseFactoryProvider.getConfigurationFactory()
+ .getConfiguration();
int maxCacheDuration =
config.getInt(QueryServices.CLIENT_CONNECTION_CACHE_MAX_DURATION_MILLISECONDS,
QueryServicesOptions.DEFAULT_CLIENT_CONNECTION_CACHE_MAX_DURATION);
RemovalListener<ConnectionInfo, ConnectionQueryServices>
cacheRemovalListener =
new RemovalListener<ConnectionInfo, ConnectionQueryServices>() {
@Override
public void onRemoval(RemovalNotification<ConnectionInfo,
ConnectionQueryServices> notification) {
String connInfoIdentifier =
notification.getKey().toString();
- LOGGER.debug("Expiring " + connInfoIdentifier + " because
of "
- + notification.getCause().name());
+ if (LOGGER.isDebugEnabled()) {
Review comment:
thanks review, pheonix checkstyle do have, but logger use by this in
industry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Set properties is invalid
> -------------------------
>
> Key: PHOENIX-6050
> URL: https://issues.apache.org/jira/browse/PHOENIX-6050
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.13.1, 5.0.0
> Environment: phoenix 4.13.1
> hbase 1.3.1
> Reporter: Chao Wang
> Assignee: Chao Wang
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6050.master.001.patch,
> PHOENIX-6050.master.002.patch
>
>
> I set properties in client, which are "phoenix.query.threadPoolSize", but
> this is invalid. ThreadPool always use default value (128).
> code is:
> Properties properties = new Properties();
> properties.setProperty("phoenix.query.threadPoolSize","300");
> PropertiesResolve phoenixpr = new PropertiesResolve();
> String phoenixdriver =
> phoenixpr.readMapByKey("com/main/SyncData.properties", "phoenix_driver");
> String phoenixjdbc = phoenixpr.readMapByKey("com/main/SyncData.properties",
> "phoenix_jdbc");
> Class.forName(phoenixdriver);
> return DriverManager.getConnection(phoenixjdbc,properties);
> throw is:
> Error: Task
> org.apache.phoenix.job.JobManager$InstrumentedJobFutureTask@6e91893 rejected
> from org.apache.phoenix.job.JobManager$1@26ae880a[Running, pool size = 128,
> active threads = 128, queued tasks = 5000, completed tasks = 36647]
> (state=08000,code=101)
> org.apache.phoenix.exception.PhoenixIOException: Task
> org.apache.phoenix.job.JobManager$InstrumentedJobFutureTask@6e91893 rejected
> from org.apache.phoenix.job.JobManager$1@26ae880a[Running, pool size = 128,
> active threads = 128, queued tasks = 5000, completed tasks = 36647]
> at
> org.apache.phoenix.util.ServerUtil.parseServerException(ServerUtil.java:120)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1024)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:916)
> ^Reason:^
> I find PhoenixDriver create threadpool before init config from properties.
> when create threadpool , config is always default value .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
