[
https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259522#comment-17259522
]
ASF GitHub Bot commented on PHOENIX-6050:
-----------------------------------------
yanxinyi commented on a change in pull request #1064:
URL: https://github.com/apache/phoenix/pull/1064#discussion_r552451886
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -184,22 +184,22 @@
public abstract class BaseTest {
public static final String DRIVER_CLASS_NAME_ATTRIB =
"phoenix.driver.class.name";
private static final double ZERO = 1e-9;
- private static final Map<String,String> tableDDLMap;
+ private static final Map<String, String> tableDDLMap;
private static final Logger LOGGER =
LoggerFactory.getLogger(BaseTest.class);
@ClassRule
public static TemporaryFolder tmpFolder = new TemporaryFolder();
- private static final int dropTableTimeout = 300; // 5 mins should be long
enough.
- private static final ThreadFactory factory = new
ThreadFactoryBuilder().setDaemon(true)
+ private static final int DROP_TABLE_TIMEOUT = 300; // 5 mins should be
long enough.
Review comment:
Nice coding style changing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Set properties is invalid
> -------------------------
>
> Key: PHOENIX-6050
> URL: https://issues.apache.org/jira/browse/PHOENIX-6050
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.13.1, 5.0.0
> Environment: phoenix 4.13.1
> hbase 1.3.1
> Reporter: Chao Wang
> Assignee: Chao Wang
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6050.master.001.patch,
> PHOENIX-6050.master.002.patch
>
>
> I set properties in client, which are "phoenix.query.threadPoolSize", but
> this is invalid. ThreadPool always use default value (128).
> code is:
> Properties properties = new Properties();
> properties.setProperty("phoenix.query.threadPoolSize","300");
> PropertiesResolve phoenixpr = new PropertiesResolve();
> String phoenixdriver =
> phoenixpr.readMapByKey("com/main/SyncData.properties", "phoenix_driver");
> String phoenixjdbc = phoenixpr.readMapByKey("com/main/SyncData.properties",
> "phoenix_jdbc");
> Class.forName(phoenixdriver);
> return DriverManager.getConnection(phoenixjdbc,properties);
> throw is:
> Error: Task
> org.apache.phoenix.job.JobManager$InstrumentedJobFutureTask@6e91893 rejected
> from org.apache.phoenix.job.JobManager$1@26ae880a[Running, pool size = 128,
> active threads = 128, queued tasks = 5000, completed tasks = 36647]
> (state=08000,code=101)
> org.apache.phoenix.exception.PhoenixIOException: Task
> org.apache.phoenix.job.JobManager$InstrumentedJobFutureTask@6e91893 rejected
> from org.apache.phoenix.job.JobManager$1@26ae880a[Running, pool size = 128,
> active threads = 128, queued tasks = 5000, completed tasks = 36647]
> at
> org.apache.phoenix.util.ServerUtil.parseServerException(ServerUtil.java:120)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1024)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:916)
> ^Reason:^
> I find PhoenixDriver create threadpool before init config from properties.
> when create threadpool , config is always default value .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
