[
https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259525#comment-17259525
]
ASF GitHub Bot commented on PHOENIX-6050:
-----------------------------------------
yanxinyi commented on a change in pull request #1064:
URL: https://github.com/apache/phoenix/pull/1064#discussion_r552453450
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixEmbeddedDriver.java
##########
@@ -91,8 +89,15 @@
protected ReadOnlyProps getDefaultProps() {
return DEFAULT_PROPS;
}
-
- abstract public QueryServices getQueryServices() throws SQLException;
+
+ /**
+ * get query services
+ * @param info properties info
+ * @return query services
+ * @throws SQLException if failed to get query service.
+ */
+ public abstract QueryServices getQueryServices(Properties info)
Review comment:
I see. You made an interface changes. I would suggest keep the original
method with depreciation tag and remove it after two release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Set properties is invalid
> -------------------------
>
> Key: PHOENIX-6050
> URL: https://issues.apache.org/jira/browse/PHOENIX-6050
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.13.1, 5.0.0
> Environment: phoenix 4.13.1
> hbase 1.3.1
> Reporter: Chao Wang
> Assignee: Chao Wang
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6050.master.001.patch,
> PHOENIX-6050.master.002.patch
>
>
> I set properties in client, which are "phoenix.query.threadPoolSize", but
> this is invalid. ThreadPool always use default value (128).
> code is:
> Properties properties = new Properties();
> properties.setProperty("phoenix.query.threadPoolSize","300");
> PropertiesResolve phoenixpr = new PropertiesResolve();
> String phoenixdriver =
> phoenixpr.readMapByKey("com/main/SyncData.properties", "phoenix_driver");
> String phoenixjdbc = phoenixpr.readMapByKey("com/main/SyncData.properties",
> "phoenix_jdbc");
> Class.forName(phoenixdriver);
> return DriverManager.getConnection(phoenixjdbc,properties);
> throw is:
> Error: Task
> org.apache.phoenix.job.JobManager$InstrumentedJobFutureTask@6e91893 rejected
> from org.apache.phoenix.job.JobManager$1@26ae880a[Running, pool size = 128,
> active threads = 128, queued tasks = 5000, completed tasks = 36647]
> (state=08000,code=101)
> org.apache.phoenix.exception.PhoenixIOException: Task
> org.apache.phoenix.job.JobManager$InstrumentedJobFutureTask@6e91893 rejected
> from org.apache.phoenix.job.JobManager$1@26ae880a[Running, pool size = 128,
> active threads = 128, queued tasks = 5000, completed tasks = 36647]
> at
> org.apache.phoenix.util.ServerUtil.parseServerException(ServerUtil.java:120)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1024)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:916)
> ^Reason:^
> I find PhoenixDriver create threadpool before init config from properties.
> when create threadpool , config is always default value .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
