[
https://issues.apache.org/jira/browse/PHOENIX-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269151#comment-17269151
]
ASF GitHub Bot commented on PHOENIX-6333:
-----------------------------------------
stoty commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561708911
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
3.1.2 is not the latest version it supports, it's just the default.
(Even HBase branch-2.4 and master uses Hadoop 3.1.2 as default)
There seems to be no problem with using Hadoop 3.1.3 with Hbase 2.2 and 2.3,
nor with using 3.1.4 with 2.4.
On one hand, we get bug, security and performance fixes when using a later
(compatible) version.
On the other hand, simply sticking to the Hbase default version also has
merit, as we can avoid the kind of problems that the last upgrade has created.
This only affects the defaults, and the binary distributions, end users are
free to build with wathever version they choose.
I am running a set of builds with HBase 2.1/2.2/2.3 and Hadoop
3.0.3/3.1.3/3.1.3 respectively, so we'll know more in about an hour.
I do not have a firm opinon either way, if you think that we should simnply
revert PHOENIX-6326, that is also possible.
Provided that the tests with the above combinations are clean, would you
prefer the 3.0.3/3.1.3/3.1.3/3.1.4 version or the old 3.0.3/3.1.2/3.1.2/3.1.2 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Hbase versions older than 2.4.0 are incompatible with Hadoop 3.1.4
> ------------------------------------------------------------------
>
> Key: PHOENIX-6333
> URL: https://issues.apache.org/jira/browse/PHOENIX-6333
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Blocker
>
> In PHOENIX-6326 I've upgraded Hadoop to 3.1.4 to solve a test failure caused
> by older Jetty versions.
> It turns out that only HBase 2.4 is compatible with the new Jetty in 3.1.4,
> (it uses a shaded jetty), but earlier versions are not.
> Unfortunately, this happened right after we swicthed Yetus to to use Hbase
> 2.4, so the procommit checks didn't catch this.
> Technically, neither the Phoenix client or server runtime artifacts are
> affected by this, as the server doesn't include HBase, and the client doesn'
> use jetty.
> Considering that any pre-2.4.0 HBase version is incompatible with Hadoop
> 3.1.4, I think that the best option to use Hadoop 3.1.3 in those profiles.
> As any pre-2.4.0 HBase is incompatible (at least on ther server side) with
> the problematic Java releases,
> we are not really losing anything by not supporting building releases with
> this profiles in Phoenix.
> Furthermore, it turns out that even minor hadoop releases are not ABI
> compatible.
> Rebuilding HBase 2.1 with hadoop.profile=3.0, which uses Hadoop 3.0.3, and
> then building Phoenix with Hadoop 3.1.3 will result in the usual
> Class<->Interface errors.
> While building Hbase 2.1 with _hadoop.profile=3.0 hadoop.version=3.1.3_ seems
> to resolve this, I think that sticiking with same Hadoop minor version that
> HBase defaults to in each profile will be simpler, and more likely to be
> compatible with user environments.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
