[ 
https://issues.apache.org/jira/browse/PHOENIX-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269194#comment-17269194
 ] 

ASF GitHub Bot commented on PHOENIX-6333:
-----------------------------------------

stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764534499


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  1s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  15m 22s |  master passed  |
   | +0 |  hbaserecompile  |  22m 24s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 32s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 20s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   8m 32s |  the patch passed  |
   | +0 |  hbaserecompile  |  17m 14s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   2m  0s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  0s |  the patch passed  |
   | +1 :green_heart: |  markdownlint  |   0m  5s |  The patch generated 0 new 
+ 29 unchanged - 1 fixed = 29 total (was 30)  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  shelldocs  |   0m  4s |  There were no new shelldocs 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   1m 38s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 152m 23s |  root in the patch failed.  |
   | -1 :x: |  asflicense  |   1m 12s |  The patch generated 610 ASF License 
warnings.  |
   |  |   | 202m 11s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | phoenix.rpc.UpdateCacheIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1103 |
   | Optional Tests | dupname asflicense markdownlint shellcheck shelldocs 
javac javadoc unit xml compile |
   | uname | Linux 0ae8acb7fd45 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / e74857b |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/testReport/
 |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 10416 (vs. ulimit of 30000) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 markdownlint=0.22.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Hbase versions older than 2.4.0 are incompatible with Hadoop 3.1.4
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-6333
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6333
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 5.1.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Blocker
>
> In PHOENIX-6326 I've upgraded Hadoop to 3.1.4 to solve a test failure caused 
> by older Jetty versions.
> It turns out that only HBase 2.4 is compatible with the new Jetty in 3.1.4, 
> (it uses a shaded jetty), but earlier versions are not.
> Unfortunately, this happened right after we swicthed Yetus to to use Hbase 
> 2.4, so the procommit checks didn't catch this.
> Technically, neither the Phoenix client or server runtime artifacts are 
> affected by this, as the server doesn't include HBase, and the client doesn' 
> use jetty.
> Considering that any pre-2.4.0 HBase version is incompatible with Hadoop 
> 3.1.4, I think that the best option to use Hadoop 3.1.3 in those profiles.
> As any pre-2.4.0 HBase is incompatible (at least on ther server side) with 
> the problematic Java releases, 
> we are not really losing anything by not supporting building releases with 
> this profiles in Phoenix.
> Furthermore, it turns out that even minor hadoop releases are not ABI 
> compatible.
> Rebuilding HBase 2.1 with hadoop.profile=3.0, which uses Hadoop 3.0.3, and 
> then building Phoenix with Hadoop 3.1.3 will result in the usual 
> Class<->Interface errors.
> While building Hbase 2.1 with _hadoop.profile=3.0 hadoop.version=3.1.3_ seems 
> to resolve this, I think that sticiking with same Hadoop minor version that 
> HBase defaults to in each profile will be simpler, and more likely to be 
> compatible with user environments.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to