[ 
https://issues.apache.org/jira/browse/PHOENIX-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269185#comment-17269185
 ] 

ASF GitHub Bot commented on PHOENIX-6333:
-----------------------------------------

virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561745498



##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
         <hbase.version>${hbase-2.3.runtime.version}</hbase.version>
         <hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
         <zookeeper.version>3.5.7</zookeeper.version>
+        <hadoop.version>3.1.3</hadoop.version>

Review comment:
       > I do not have a firm opinon either way, if you think that we should 
simnply revert PHOENIX-6326, that is also possible.
   
   I also don't have firm opinion either. I think this might take a while doing 
testing and all, maybe bake in multibranch build for few days and once we see 
things clear, maybe we should proceed. Given all the work you have done, i 
think good to proceed with updated Hadoop versions. Only if it turns out to 
significant tests failing due to Hadoop upgrade, maybe we can revert and take 
some time with individual HBase profiles. If we go in this situation, please 
let me know, i will try to test specific HBase profile and try to help ensure 
the least latest Hadoop version that we can support.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Hbase versions older than 2.4.0 are incompatible with Hadoop 3.1.4
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-6333
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6333
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 5.1.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Blocker
>
> In PHOENIX-6326 I've upgraded Hadoop to 3.1.4 to solve a test failure caused 
> by older Jetty versions.
> It turns out that only HBase 2.4 is compatible with the new Jetty in 3.1.4, 
> (it uses a shaded jetty), but earlier versions are not.
> Unfortunately, this happened right after we swicthed Yetus to to use Hbase 
> 2.4, so the procommit checks didn't catch this.
> Technically, neither the Phoenix client or server runtime artifacts are 
> affected by this, as the server doesn't include HBase, and the client doesn' 
> use jetty.
> Considering that any pre-2.4.0 HBase version is incompatible with Hadoop 
> 3.1.4, I think that the best option to use Hadoop 3.1.3 in those profiles.
> As any pre-2.4.0 HBase is incompatible (at least on ther server side) with 
> the problematic Java releases, 
> we are not really losing anything by not supporting building releases with 
> this profiles in Phoenix.
> Furthermore, it turns out that even minor hadoop releases are not ABI 
> compatible.
> Rebuilding HBase 2.1 with hadoop.profile=3.0, which uses Hadoop 3.0.3, and 
> then building Phoenix with Hadoop 3.1.3 will result in the usual 
> Class<->Interface errors.
> While building Hbase 2.1 with _hadoop.profile=3.0 hadoop.version=3.1.3_ seems 
> to resolve this, I think that sticiking with same Hadoop minor version that 
> HBase defaults to in each profile will be simpler, and more likely to be 
> compatible with user environments.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to