[
https://issues.apache.org/jira/browse/PHOENIX-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285106#comment-17285106
]
ASF GitHub Bot commented on PHOENIX-6359:
-----------------------------------------
virajjasani commented on a change in pull request #1143:
URL: https://github.com/apache/phoenix/pull/1143#discussion_r576662976
##########
File path: pom.xml
##########
@@ -86,12 +87,13 @@
<hbase.suffix>hbase-${hbase.profile}</hbase.suffix>
<!-- This is used by the release script only -->
- <hbase.profile.list>2.1 2.2 2.3 2.4</hbase.profile.list>
+ <hbase.profile.list>2.1 2.2 2.3 2.4 2.4.1</hbase.profile.list>
Review comment:
> In this case, we should rename the profile names, as 2.4 working with
2.4.0 instead of the latest version is counter-intuitive.
Agree, sounds good.
> The other soultion, that I originally had in mind was to map the profiles
to the latest supported patch level, and only build official binaries for those.
Hmm, although this is doable but for latest releases, it might not be in our
best interest to make users stick to a particular patch release?
On the other hand, we could make decisions on the basis of the what urgency
does HBase patch release bring? For instance, 2.4.1 has some critical
authorization fixes, which made 2.4.1 to come out way ahead of the schedule.
For such urgent releases, it might be good to support them sooner, but for
non-critical patch release that cause compatibility issues in Phoenix, we might
want to wait little longer.
Anyways, if you are fine with supporting first approach (new profile for
2.4.1), I will also raise another Jira to remove HBase 2.1 support in Phoenix
5.2. One less profile for 5.2 for now. WDYT?
Moreover, I understand the pain with ever increasing profiles. As far as
running tests are concerned in multibranch, perhaps, we could limit it to
latest 4 profiles?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> New module to support HBase 2.4.1+ releases
> -------------------------------------------
>
> Key: PHOENIX-6359
> URL: https://issues.apache.org/jira/browse/PHOENIX-6359
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.1.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.1, 5.2.0
>
>
> As we know HStore IA.Private APIs are refactored in HBASE-25249, we need to
> come up with new module to support HBase 2.4.1+ releases as of now. This
> support is not planned for 5.1.0 release though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
