[ 
https://issues.apache.org/jira/browse/PHOENIX-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285147#comment-17285147
 ] 

ASF GitHub Bot commented on PHOENIX-6359:
-----------------------------------------

virajjasani commented on a change in pull request #1143:
URL: https://github.com/apache/phoenix/pull/1143#discussion_r576753174



##########
File path: pom.xml
##########
@@ -86,12 +87,13 @@
     <hbase.suffix>hbase-${hbase.profile}</hbase.suffix>
 
     <!-- This is used by the release script only -->
-    <hbase.profile.list>2.1 2.2 2.3 2.4</hbase.profile.list>
+    <hbase.profile.list>2.1 2.2 2.3 2.4 2.4.1</hbase.profile.list>

Review comment:
       > The patclevel-less profiles always point to the latest supported HBase 
compatibility module and HBase patch release (i.e. profile 2.4 uses HBase 
2.4.1, and profile 2.4.0 uses HBase 2.4.0)
   
   I think this sounds better. And this is needed only for incompatible patch 
release, otherwise for compatible patch release we would just bump up 
`hbase.version` on pom.xml directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> New module to support HBase 2.4.1+ releases
> -------------------------------------------
>
>                 Key: PHOENIX-6359
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6359
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 5.1.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.1, 5.2.0
>
>
> As we know HStore IA.Private APIs are refactored in HBASE-25249, we need to 
> come up with new module to support HBase 2.4.1+ releases as of now. This 
> support is not planned for 5.1.0 release though.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to