[
https://issues.apache.org/jira/browse/PHOENIX-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285119#comment-17285119
]
ASF GitHub Bot commented on PHOENIX-6359:
-----------------------------------------
stoty commented on a change in pull request #1143:
URL: https://github.com/apache/phoenix/pull/1143#discussion_r576694906
##########
File path: pom.xml
##########
@@ -86,12 +87,13 @@
<hbase.suffix>hbase-${hbase.profile}</hbase.suffix>
<!-- This is used by the release script only -->
- <hbase.profile.list>2.1 2.2 2.3 2.4</hbase.profile.list>
+ <hbase.profile.list>2.1 2.2 2.3 2.4 2.4.1</hbase.profile.list>
Review comment:
Our response time to any new incompatible HBase release is not really
relevant to this issue. I think that doing a new Phoenix (patch) release ASAP
after such a release would help us be more relevant in the community.
Thinking a bit more about this, I propose the following:
- We add new profiles for each compatibility module, as you did, they are
cheap, and reduce the possibility of errors
- The patclevel-less profiles always point to the latest supported HBase
compatibility module and HBase patch release (i.e. profile 2.4 uses HBase
2.4.1, and profile 2.4.0 uses HBase 2.4.0) (though the compat-module version
and the HBase versions are usually different, as the compati-modules version is
the first supported, but we build with the éast supported HBase release)
- Profiles for older patchlevels are named after the compat-module release
- We update BULDING.md to reflect the above
- We run jenkins tests only for latest profiles (the patchlevel-less ones)
We discuss whether we want to build release artifacts for the artifacts on
the list.
(If you are fine with the above, you could start the discussion)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> New module to support HBase 2.4.1+ releases
> -------------------------------------------
>
> Key: PHOENIX-6359
> URL: https://issues.apache.org/jira/browse/PHOENIX-6359
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.1.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.1, 5.2.0
>
>
> As we know HStore IA.Private APIs are refactored in HBASE-25249, we need to
> come up with new module to support HBase 2.4.1+ releases as of now. This
> support is not planned for 5.1.0 release though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
