[
https://issues.apache.org/jira/browse/PHOENIX-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337055#comment-17337055
]
ASF GitHub Bot commented on PHOENIX-6387:
-----------------------------------------
stoty commented on pull request #1215:
URL: https://github.com/apache/phoenix/pull/1215#issuecomment-829791875
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ PHOENIX-6387-4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 52s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | compile | 1m 12s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | checkstyle | 1m 6s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | javadoc | 0m 51s | PHOENIX-6387-4.x passed |
| +0 :ok: | spotbugs | 3m 32s | phoenix-core in PHOENIX-6387-4.x has
946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 5s | the patch passed |
| +1 :green_heart: | compile | 1m 9s | the patch passed |
| +1 :green_heart: | javac | 1m 9s | the patch passed |
| -1 :x: | checkstyle | 1m 9s | phoenix-core: The patch generated 182
new + 2655 unchanged - 45 fixed = 2837 total (was 2700) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed |
| -1 :x: | spotbugs | 3m 40s | phoenix-core generated 1 new + 944
unchanged - 2 fixed = 945 total (was 946) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 216m 27s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate
ASF License warnings. |
| | | 254m 9s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Switch statement found in
org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext,
Delete) where default case is missing At IndexRegionObserver.java:Delete)
where default case is missing At IndexRegionObserver.java:[lines 682-689] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1215 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux e49400746ebf 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | PHOENIX-6387-4.x / c3f166e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/testReport/
|
| Max. process+thread count | 4966 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Conditional updates on tables with indexes
> ------------------------------------------
>
> Key: PHOENIX-6387
> URL: https://issues.apache.org/jira/browse/PHOENIX-6387
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Kadir OZDEMIR
> Assignee: Tanuj Khurana
> Priority: Major
>
> For a row update done by using the UPSERT VALUES statement, the exact values
> of the columns to be updated are specified within the UPSERT statement.
> Regardless of whether a given row exists or not, after the update, we know
> what the content will be for these columns. However, this is not the case
> when the ON DUPLICATE KEY clause is added the UPSERT VALUES statement. This
> clause makes the update conditional and the end result is determined based on
> the conditions stated within the clause and the current state of the row at
> the time the update is done. Also, this clause makes the UPSERT VALUES
> statement atomic.
> Conditional updates are supported for the tables without indexes currently.
> The current design leverages an HBase atomic operation and cannot be expanded
> to support tables with indexes since the design requires holding (HBase
> level) row locks while doing index table updates over RPCs. This results in
> cluster wide deadlocks. This jira is to redesign conditional updates using
> Phoenix level row locks instead of using HBase level row locks to also
> support tables with indexes by leveraging the design of PHOENIX-6160 which
> simplifies the concurrent mutation handling on tables with indexes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
