[
https://issues.apache.org/jira/browse/PHOENIX-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340433#comment-17340433
]
ASF GitHub Bot commented on PHOENIX-6387:
-----------------------------------------
tkhurana commented on a change in pull request #1215:
URL: https://github.com/apache/phoenix/pull/1215#discussion_r627762679
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -926,57 +1051,84 @@ private void waitForPreviousConcurrentBatch(TableName
table, BatchMutateContext
// lastContext.getMaxPendingRowCount() is the depth of the
subtree rooted at the batch pointed by lastContext
if (!countDownLatch.await((lastContext.getMaxPendingRowCount()
+ 1) * concurrentMutationWaitDuration,
TimeUnit.MILLISECONDS)) {
+ LOG.debug(String.format("latch timeout context %s last
%s", context, lastContext));
done = false;
- break;
}
// Acquire the locks again before letting the region proceed
with data table updates
lockRows(context);
+ if (!done) {
+ // previous concurrent batch did not complete so we have
to retry this batch
+ break;
+ } else {
+ // read the phase again to determine the status of
previous batch
+ phase = lastContext.getCurrentPhase();
+ LOG.debug(String.format("context %s last %s exit phase
%s", context, lastContext, phase));
Review comment:
@gjacoby126 toString() is the default implementation that returns a
string of the form of `BatchMutateContext@<hex representation of the memory
location the instantiated object>`. The intent of the log message is to see how
different batch mutate context objects are linked together so we just need a
unique id for every instantiated batch mutate context object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Conditional updates on tables with indexes
> ------------------------------------------
>
> Key: PHOENIX-6387
> URL: https://issues.apache.org/jira/browse/PHOENIX-6387
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Kadir OZDEMIR
> Assignee: Tanuj Khurana
> Priority: Major
>
> For a row update done by using the UPSERT VALUES statement, the exact values
> of the columns to be updated are specified within the UPSERT statement.
> Regardless of whether a given row exists or not, after the update, we know
> what the content will be for these columns. However, this is not the case
> when the ON DUPLICATE KEY clause is added the UPSERT VALUES statement. This
> clause makes the update conditional and the end result is determined based on
> the conditions stated within the clause and the current state of the row at
> the time the update is done. Also, this clause makes the UPSERT VALUES
> statement atomic.
> Conditional updates are supported for the tables without indexes currently.
> The current design leverages an HBase atomic operation and cannot be expanded
> to support tables with indexes since the design requires holding (HBase
> level) row locks while doing index table updates over RPCs. This results in
> cluster wide deadlocks. This jira is to redesign conditional updates using
> Phoenix level row locks instead of using HBase level row locks to also
> support tables with indexes by leveraging the design of PHOENIX-6160 which
> simplifies the concurrent mutation handling on tables with indexes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
