[
https://issues.apache.org/jira/browse/PHOENIX-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412824#comment-17412824
]
ASF GitHub Bot commented on PHOENIX-6540:
-----------------------------------------
stoty commented on pull request #1299:
URL: https://github.com/apache/phoenix/pull/1299#issuecomment-916417853
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 0s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
2 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 17s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 19s | 4.x passed |
| +1 :green_heart: | compile | 1m 46s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 6s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 27s | 4.x passed |
| +0 :ok: | spotbugs | 0m 30s | phoenix-hbase-compat-1.5.0 in 4.x has 4
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.4.0 in 4.x has 3
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.3.0 in 4.x has 3
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 4m 27s | root in 4.x has 1015 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 3m 2s | phoenix-core in 4.x has 958 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 9m 49s | the patch passed |
| +1 :green_heart: | compile | 1m 44s | the patch passed |
| +1 :green_heart: | javac | 1m 44s | the patch passed |
| -1 :x: | checkstyle | 1m 6s | root: The patch generated 55 new + 387
unchanged - 114 fixed = 442 total (was 501) |
| -1 :x: | whitespace | 0m 0s | The patch has 4 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 7s | the patch passed |
| +1 :green_heart: | spotbugs | 0m 37s | phoenix-hbase-compat-1.5.0
generated 0 new + 2 unchanged - 2 fixed = 2 total (was 4) |
| +1 :green_heart: | spotbugs | 0m 35s | phoenix-hbase-compat-1.4.0
generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3) |
| +1 :green_heart: | spotbugs | 3m 15s | phoenix-core in the patch
passed. |
| +1 :green_heart: | spotbugs | 4m 28s | root generated 0 new + 1010
unchanged - 5 fixed = 1010 total (was 1015) |
||| _ Other Tests _ |
| -1 :x: | unit | 148m 35s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate
ASF License warnings. |
| | | 213m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1299/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1299 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaseanti checkstyle |
| uname | Linux 833f2620e5c5 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9
23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 82cfcf0 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1299/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1299/1/artifact/yetus-general-check/output/whitespace-eol.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1299/1/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1299/1/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1299/1/testReport/
|
| Max. process+thread count | 5990 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0
phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1299/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Drop Hbase 1.3 support from 4.x branch
> --------------------------------------
>
> Key: PHOENIX-6540
> URL: https://issues.apache.org/jira/browse/PHOENIX-6540
> Project: Phoenix
> Issue Type: Task
> Components: core
> Affects Versions: 4.17.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> There was a discussion on removing HBase 1.3 support in 4.16, but we decided
> to keep it for 4.16 at least.
> There was no objection to removing it for 4.17.
> I propose removing HBase support from the 4.x branch (but keeping it for the
> 4.16 branch)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
