[
https://issues.apache.org/jira/browse/PHOENIX-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412937#comment-17412937
]
ASF GitHub Bot commented on PHOENIX-6540:
-----------------------------------------
stoty commented on a change in pull request #1299:
URL: https://github.com/apache/phoenix/pull/1299#discussion_r705869140
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ScanningResultIterator.java
##########
@@ -97,9 +95,7 @@ private void changeMetric(GlobalClientMetrics metric, Long
value) {
private void updateMetrics() {
if (scanMetricsEnabled && !scanMetricsUpdated) {
- ScanMetrics scanMetrics = scan.getScanMetrics();
- if (scanMetrics == null)
Review comment:
Yes, 1.3 doesn't have the metrics API that Phoenix uses, it was
specifically added for 1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Drop Hbase 1.3 support from 4.x branch
> --------------------------------------
>
> Key: PHOENIX-6540
> URL: https://issues.apache.org/jira/browse/PHOENIX-6540
> Project: Phoenix
> Issue Type: Task
> Components: core
> Affects Versions: 4.17.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> There was a discussion on removing HBase 1.3 support in 4.16, but we decided
> to keep it for 4.16 at least.
> There was no objection to removing it for 4.17.
> I propose removing HBase support from the 4.x branch (but keeping it for the
> 4.16 branch)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
