[
https://issues.apache.org/jira/browse/PHOENIX-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412873#comment-17412873
]
ASF GitHub Bot commented on PHOENIX-6540:
-----------------------------------------
gjacoby126 commented on a change in pull request #1299:
URL: https://github.com/apache/phoenix/pull/1299#discussion_r705767190
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
##########
@@ -109,20 +109,20 @@ private void snapshotAllMetrics(MetricRegistry
metricRegistry,
Map<String, Metric> metrics = metricRegistry.getMetrics();
Iterator iterator = metrics.entrySet().iterator();
- while (iterator.hasNext()) {
- Entry<String, Metric> e = (Entry) iterator.next();
+ while(iterator.hasNext()) {
+ Entry<String, Metric> e = (Entry)iterator.next();
Review comment:
tiny nit: the extra space between casted class and variable aids
readability (and removing the space it makes this patch larger). I believe our
checkstyle wants the space too, iirc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Drop Hbase 1.3 support from 4.x branch
> --------------------------------------
>
> Key: PHOENIX-6540
> URL: https://issues.apache.org/jira/browse/PHOENIX-6540
> Project: Phoenix
> Issue Type: Task
> Components: core
> Affects Versions: 4.17.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> There was a discussion on removing HBase 1.3 support in 4.16, but we decided
> to keep it for 4.16 at least.
> There was no objection to removing it for 4.17.
> I propose removing HBase support from the 4.x branch (but keeping it for the
> 4.16 branch)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
