[
https://issues.apache.org/jira/browse/PHOENIX-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430504#comment-17430504
]
ASF GitHub Bot commented on PHOENIX-5215:
-----------------------------------------
ArkenKiran commented on a change in pull request #1282:
URL: https://github.com/apache/phoenix/pull/1282#discussion_r731800779
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java
##########
@@ -371,11 +372,11 @@ public final ResultIterator iterator(final
Map<ImmutableBytesPtr,ServerCache> ca
}
// wrap the iterator so we start/end tracing as we expect
- if (Tracing.isTracing()) {
- TraceScope scope = Tracing.startNewSpan(context.getConnection(),
- "Creating basic query for " + getPlanSteps(iterator));
- if (scope.getSpan() != null) return new TracingIterator(scope,
iterator);
- }
+
+ Span span = TraceUtil.getGlobalTracer().spanBuilder("Creating basic
query for " + getPlanSteps(iterator)).startSpan();
+
+ if (span.isRecording()) return new TracingIterator(span, iterator);
Review comment:
@richardantal default implementation shows it as false. I will take a
look at it in depth and see how we can enable TracingIterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove and replace HTrace
> -------------------------
>
> Key: PHOENIX-5215
> URL: https://issues.apache.org/jira/browse/PHOENIX-5215
> Project: Phoenix
> Issue Type: Bug
> Reporter: Andrew Kyle Purtell
> Assignee: Kiran Kumar Maturi
> Priority: Major
>
> HTrace is dead.
> Hadoop is discussing a replacement of HTrace with OpenTracing, see
> HADOOP-15566
> HBase is having the same discussion on HBASE-22120
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
