[ 
https://issues.apache.org/jira/browse/PHOENIX-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430514#comment-17430514
 ] 

ASF GitHub Bot commented on PHOENIX-5215:
-----------------------------------------

ArkenKiran commented on a change in pull request #1282:
URL: https://github.com/apache/phoenix/pull/1282#discussion_r731815167



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/trace/TraceReader.java
##########
@@ -47,6 +46,7 @@
 public class TraceReader {
 
     private static final Logger LOGGER = 
LoggerFactory.getLogger(TraceReader.class);
+    public static final long ROOT_SPAN_ID = 0x74ace;

Review comment:
       @dbwong I am not sure if we need TraceReader anymore, considering we can 
view the traces on exporter ui (like zipking or jaeger). I wanted to discuss 
about TracingWebApplication as well in the JIRA will comment there




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Remove and replace HTrace
> -------------------------
>
>                 Key: PHOENIX-5215
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5215
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Andrew Kyle Purtell
>            Assignee: Kiran Kumar Maturi
>            Priority: Major
>
> HTrace is dead.
> Hadoop is discussing a replacement of HTrace with OpenTracing, see 
> HADOOP-15566 
> HBase is having the same discussion on HBASE-22120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to