[
https://issues.apache.org/jira/browse/PHOENIX-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430510#comment-17430510
]
ASF GitHub Bot commented on PHOENIX-5215:
-----------------------------------------
ArkenKiran commented on a change in pull request #1282:
URL: https://github.com/apache/phoenix/pull/1282#discussion_r731812360
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelIterators.java
##########
@@ -118,10 +119,11 @@ protected void submitWork(final List<List<Scan>>
nestedScans, List<List<Pair<Sca
mutationState, tableRef, scan, scanMetricsHolder,
renewLeaseThreshold, plan,
scanGrouper, caches);
context.getConnection().addIteratorForLeaseRenewal(tableResultItr);
- Future<PeekingResultIterator> future =
executor.submit(Tracing.wrap(new JobCallable<PeekingResultIterator>() {
+ Future<PeekingResultIterator> future = executor.submit(new
JobCallable<PeekingResultIterator>() {
@Override
public PeekingResultIterator call() throws Exception {
+ //TODO: create child span for each call using parent
Review comment:
@dbwong yes i had updated the implementation. was seeing issues so had
to disable it. Will take a look at it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove and replace HTrace
> -------------------------
>
> Key: PHOENIX-5215
> URL: https://issues.apache.org/jira/browse/PHOENIX-5215
> Project: Phoenix
> Issue Type: Bug
> Reporter: Andrew Kyle Purtell
> Assignee: Kiran Kumar Maturi
> Priority: Major
>
> HTrace is dead.
> Hadoop is discussing a replacement of HTrace with OpenTracing, see
> HADOOP-15566
> HBase is having the same discussion on HBASE-22120
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
