alejandro-anadon commented on PR #1458:
URL: https://github.com/apache/phoenix/pull/1458#issuecomment-1184451952
After the last commit I reached a stopping point.
I would like to continue but I will need someone to tell me how to proced on
what I had said in my previous comment.
Almost everything comes from the reports that Apache Yetus(jenkins) puts
out. To summarize:
1) PUUID, PUUIDIndexable and PUUIDArray (error: spotbugs ->
HE_INHERITS_EQUALS_USE_HASHCODE: Class inherits equals() and uses
Object.hashCode()):
It is a warning, not error, but should they implement the 'hashCode()'
and/or 'equals()' methods even though the other types do not?
2) how do I solve the following checkstyles errors: [IllegalInstantiation]
with the String? should I use another class?
for example:
"./phoenix-core/src/main/java/org/apache/phoenix/util/UUIDUtil.java:83:
uuidStr = new String(temp, Charset.forName("UTF-8"));
:27: Instantiation of java.lang.String should be avoided.
[IllegalInstantiation]"
3) Is it ok or do I have to correct the above question regarding
StringToUUIDFunction.evaluate() and UUIDFunctionTest.testUUIDFunctions() ?
4) sqlTypes ids for PUUID -> 2100 and PUUIDIndexable -> 2101: are they
correct ?
5) is the following logic correct?
assertTrue(PUUID.INSTANCE.isCoercibleTo(PUUIDIndexable.INSTANCE));
assertFalse(PUUIDIndexable.INSTANCE.isCoercibleTo(PUUID.INSTANCE));
6) The errors that 'Apache Yetus(jenkins) error: unit' are reporting
("InListIT.cleanUp:88 refCount leaked",
"MapReduceIT.clearCountersForScanGrouper:93 refCount leaked" and others):
are they really errors?
The tests I run localy don't give me any errors (except some of
"NeedTheirOwnClusterTests" but
@stoty told me in another fix that "[...]there are also some flaky tests, so
that's OK"). I am testing against hbase 2.4.1.
I attach the log.
7) should I fix checkstyles errors (Indentation and WhitespaceAfter) that
were before the changes and that have nothing
to do with the changes I apply?
Thank you
[tests
logs.txt](https://github.com/apache/phoenix/files/9112168/tests.logs.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
