alejandro-anadon commented on PR #1458:
URL: https://github.com/apache/phoenix/pull/1458#issuecomment-1209415266
You can ignore point number 6. I guess @stoty has changed/fixed something in
'Apache Yetus(jenkins) error: unit' and,
as I imagined, no longer gives unit errors of type "InListIT.cleanUp:88
refCount leaked" (or any other error) in this branch.
But they still appear:
-checkstyles errors: 'Instantiation of java.lang.String should be avoided.
[IllegalInstantiation]' (how do I instate Strings?)
-errors of type 'child has incorrect indentation level 4, expected level
should be 8. [Indentation]'.
which I think it would be a mistake to indent them to level 8 because the
rest of the code is indented to level 4.
- HE_INHERITS_EQUALS_USE_HASHCODE: Class inherits equals() and uses
Object.hashCode()): in classes PUUID, PUUIDIndexable and PUUIDArray .
It is a warning, not error, but I do not know if should they be
implement the 'hashCode()' and/or 'equals()' methods even
though the other types do not.
do not leave out the question about StringToUUIDFunction.evaluate() and
UUIDFunctionTest.testUUIDFunctions()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
