alejandro-anadon commented on code in PR #1458:
URL: https://github.com/apache/phoenix/pull/1458#discussion_r969418267


##########
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java:
##########
@@ -519,6 +519,74 @@ protected Random initialValue() {
         }
     };
 
+    // Ordinal list. It makes easy to "reorder" cardinals. for instance, UUID 
and UUID_INDEXABLE

Review Comment:
   Sorry, I don't quite understand the question.
   When I say 'reorder' I mean that if we need to reorder other cardinals in 
the future (for example, let's imagine that we want to add another type 
'ipnetwork'), since they are constants in the file, it would be easier. For 
example, by incorporating the ORDINAL_UUID and ORDINAL_UUID_INDEXABLE, this way 
is easy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to