gjacoby126 commented on code in PR #1462:
URL: https://github.com/apache/phoenix/pull/1462#discussion_r924792938
##########
phoenix-core/pom.xml:
##########
@@ -568,6 +568,26 @@
</dependency>
<!-- Other test dependencies -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
Review Comment:
By including log4j-core as a test dependency, do we create a problem if
someone tries to use phoenix-core as a library in an application that wants to
use logback / another slf4j implementation and then writes a test using Phoenix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
