stoty commented on code in PR #1462:
URL: https://github.com/apache/phoenix/pull/1462#discussion_r925163186
##########
phoenix-core/pom.xml:
##########
@@ -568,6 +568,26 @@
</dependency>
<!-- Other test dependencies -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
Review Comment:
Also, currently in 5.1 we replace log4j with reload4j, but only in the
assembly, and the phoenix-client JAR.
If one depends directly on phoenix-core, it will still pull log4j
transitively via hadoop.
(Do you think we should do somthing about this in 5.1 ? )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
