stoty commented on code in PR #1462:
URL: https://github.com/apache/phoenix/pull/1462#discussion_r925162314
##########
phoenix-core/pom.xml:
##########
@@ -568,6 +568,26 @@
</dependency>
<!-- Other test dependencies -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
Review Comment:
The real change here (not in this specific fix, but in the original log4j2
commit) is that previously, phoenix-core transitively pulled in log4j1 via
hadoop-common (compile scope), but we're excluding that now, so for 5.2 the
user will need to add some kind of logging backend explicitly if he depends on
phoenix-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
