stoty commented on code in PR #1480:
URL: https://github.com/apache/phoenix/pull/1480#discussion_r943662564
##########
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java:
##########
@@ -376,10 +377,14 @@ private static void
preSplitSequenceTable(PhoenixConnection conn, int nSaltBucke
* @return
* @throws IOException
*/
- private static org.apache.hadoop.hbase.client.Connection
getHBaseConnection(Map<String, String> options)
+ private static org.apache.hadoop.hbase.client.Connection
getHBaseConnection(Configuration config, Map<String, String> options)
throws IOException {
Configuration conf = HBaseConfiguration.create();
+
+ Configuration oldconf = HBaseConfiguration.create(config);
Review Comment:
Simply use
`Configuration conf = HBaseConfiguration.create(config);`
and you'll automatically get all properties, including ZK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
