stoty commented on code in PR #1480:
URL: https://github.com/apache/phoenix/pull/1480#discussion_r943678114
##########
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java:
##########
@@ -1338,9 +1347,30 @@ public static void
moveOrCopyChildLinks(PhoenixConnection oldMetaConnection, Map
} catch (IOException ioe) {
LOGGER.error(String.format(
"Failed adding child link rows from %s to %s with
Exception :",
- SYSTEM_CATALOG_NAME, SYSTEM_CHILD_LINK_NAME), ioe);
+ systemCatalog, SYSTEM_CHILD_LINK_NAME), ioe);
throw ioe;
}
+ }
+
+ /**
+ * Wrapper around moveOrCopyChildLinksInner, we try move or copy child
links from SYSTEM.CATALOG and SYSTEM:CATALOG
+ * @param oldMetaConnection caller should take care of closing the passed
connection appropriately
+ * @throws SQLException
+ */
+
+ public static void moveOrCopyChildLinks(PhoenixConnection
oldMetaConnection, Map<String, String> options) throws IOException {
Review Comment:
This is the wrong workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
