richardantal commented on code in PR #1480:
URL: https://github.com/apache/phoenix/pull/1480#discussion_r945648027
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/LoadSystemTableSnapshotIT.java:
##########
@@ -112,7 +161,16 @@ private static void importSnapshot(String key, String
value) throws IOException
}
@Test
- public void testDummy() throws Exception {
+ public void testPhoenixUpgrade() throws Exception {
+ Map<String, String> serverProps = Maps.newHashMapWithExpectedSize(2);
+ serverProps.put(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB,
QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
+ serverProps.put(QueryServices.IS_NAMESPACE_MAPPING_ENABLED, "true");
+ Map<String, String> clientProps = Maps.newHashMapWithExpectedSize(2);
+ clientProps.put(QueryServices.IS_NAMESPACE_MAPPING_ENABLED, "true");
+
+ //Now we can start Phoenix
+ setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()),
new ReadOnlyProps(clientProps.entrySet()
+ .iterator()));
assertTrue(true);
Review Comment:
I think, yes
If you see the tests results in my [other
PR](https://github.com/apache/phoenix/pull/1485), without the PHOENIX-6754 fix,
that fails with
`org.apache.phoenix.schema.ColumnNotFoundException: ERROR 504 (42703):
Undefined column. columnName=SYSTEM.CATALOG.COLUMN_QUALIFIER`
Test run on this one is successful.
Will update this and the other PR, based on the things you suggested but it
would be better to merge PHOENIX-6754 before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
