[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730663#comment-17730663
]
ASF GitHub Bot commented on PHOENIX-6962:
-----------------------------------------
virajjasani commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1223400738
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -354,7 +354,11 @@ private List<PTable>
getClientSideMaintainedIndexes(TableRef tableRef) {
}
return Collections.emptyList();
}
-
+
+ /**
+ * Implementation of MutationPlan that is selected if there is no index
presented for a table
+ * and no LIMIT clause in the DELETE statement.
+ */
public class MultiRowDeleteMutationPlan implements MutationPlan {
Review Comment:
let's also add that this plan gets selected if the query is strictly point
lookup?
> Write javadoc for different mutation plans within DeleteCompiler.
> -----------------------------------------------------------------
>
> Key: PHOENIX-6962
> URL: https://issues.apache.org/jira/browse/PHOENIX-6962
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Reporter: Rushabh Shah
> Assignee: Jing Yu
> Priority: Minor
>
> There are multiple mutation plan within DeleteCompiler:
> # MultiRowDeleteMutationPlan
> # SingleRowDeleteMutationPlan
> # ServerSelectDeleteMutationPlan
> # ClientSelectDeleteMutationPlan
> It doesn't have javadocs explaining which mutation plan is selected for a
> given delete statement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
