[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730713#comment-17730713
]
ASF GitHub Bot commented on PHOENIX-6962:
-----------------------------------------
virajjasani commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1223527757
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -748,6 +757,14 @@ public Long getEstimateInfoTimestamp() throws SQLException
{
}
}
+ /**
+ * Implementation of MutationPlan that is selected if
+ * 1) there are mutable indexes presented for the table,
+ * 2) auto commit is on,
+ * 3) the table is not transactional,
+ * 4) there is no WHERE clause, and
+ * 5) no LIMIT clause in the DELETE statement.
Review Comment:
every plan except `MultiRowDeleteMutationPlan` can have LIMIT and WHERE
correct?
i might have misread earlier, otherwise would have commented, sorry.
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -354,7 +354,11 @@ private List<PTable>
getClientSideMaintainedIndexes(TableRef tableRef) {
}
return Collections.emptyList();
}
-
+
+ /**
+ * Implementation of MutationPlan that is selected if there is no index
presented for a table
+ * and no LIMIT clause in the DELETE statement.
+ */
public class MultiRowDeleteMutationPlan implements MutationPlan {
Review Comment:
`the query is strictly point lookup` => `the query either has no WHERE
clause or it is strictly point lookup`
> Write javadoc for different mutation plans within DeleteCompiler.
> -----------------------------------------------------------------
>
> Key: PHOENIX-6962
> URL: https://issues.apache.org/jira/browse/PHOENIX-6962
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Reporter: Rushabh Shah
> Assignee: Jing Yu
> Priority: Minor
>
> There are multiple mutation plan within DeleteCompiler:
> # MultiRowDeleteMutationPlan
> # SingleRowDeleteMutationPlan
> # ServerSelectDeleteMutationPlan
> # ClientSelectDeleteMutationPlan
> It doesn't have javadocs explaining which mutation plan is selected for a
> given delete statement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
