virajjasani commented on code in PR #1681:
URL: https://github.com/apache/phoenix/pull/1681#discussion_r1337825009
##########
bin/sqlline.py:
##########
@@ -114,6 +116,7 @@ def kill_child():
disable_jna = ""
java_cmd = java + ' $PHOENIX_OPTS ' + \
+ (args.debug and
"-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=127.0.0.1:8071" or
"") + \
Review Comment:
this is local change right?
##########
bin/sqlline.py:
##########
@@ -123,8 +126,11 @@ def kill_child():
'" -Dlog4j2.configurationFile=file:' +
os.path.join(phoenix_utils.current_dir, "log4j2.properties") + \
disable_jna + \
" sqlline.SqlLine -d org.apache.phoenix.jdbc.PhoenixDriver" + \
- " -u jdbc:phoenix:" + phoenix_utils.shell_quote([zookeeper]) + \
- " -n none -p none --color=" + colorSetting + " --fastConnect=" +
tryDecode(args.fastconnect) + \
- " --verbose=" + tryDecode(args.verbose) + " --incremental=false
--isolation=TRANSACTION_READ_COMMITTED " + sqlfile
+ (not args.noconnect and " -u jdbc:phoenix:" +
phoenix_utils.shell_quote([zookeeper]) or "") + \
Review Comment:
same here, all changes in this file can be removed
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCMiscIT.java:
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.end2end;
+
+import org.apache.phoenix.exception.SQLExceptionCode;
+import org.apache.phoenix.query.BaseTest;
+import org.apache.phoenix.util.SchemaUtil;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.Properties;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.fail;
+
+@Category(ParallelStatsDisabledTest.class)
+public class CDCMiscIT extends ParallelStatsDisabledIT {
+ private void assertCDCState(Connection conn, String cdcName, String
expInclude,
+ int idxType) throws SQLException {
+ try (ResultSet rs = conn.createStatement().executeQuery("SELECT
cdc_include FROM " +
Review Comment:
Once all the SELECT queries to SYSTEM.CATALOG are replaced with PTable based
comparison, we are good to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
