virajjasani commented on code in PR #1681:
URL: https://github.com/apache/phoenix/pull/1681#discussion_r1339390716
##########
bin/sqlline.py:
##########
@@ -123,8 +126,11 @@ def kill_child():
'" -Dlog4j2.configurationFile=file:' +
os.path.join(phoenix_utils.current_dir, "log4j2.properties") + \
disable_jna + \
" sqlline.SqlLine -d org.apache.phoenix.jdbc.PhoenixDriver" + \
- " -u jdbc:phoenix:" + phoenix_utils.shell_quote([zookeeper]) + \
- " -n none -p none --color=" + colorSetting + " --fastConnect=" +
tryDecode(args.fastconnect) + \
- " --verbose=" + tryDecode(args.verbose) + " --incremental=false
--isolation=TRANSACTION_READ_COMMITTED " + sqlfile
+ (not args.noconnect and " -u jdbc:phoenix:" +
phoenix_utils.shell_quote([zookeeper]) or "") + \
Review Comment:
yeah i think separate Jira would be better to track it and others can also
review, i am not actually sure whether we can make the change or not because at
least we don't use this script as is in production env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
