lokiore commented on code in PR #1681:
URL: https://github.com/apache/phoenix/pull/1681#discussion_r1340698096
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -4107,6 +4109,9 @@ protected PhoenixConnection
upgradeSystemCatalogIfRequired(PhoenixConnection met
metaConnection = addColumnsIfNotExists(metaConnection,
PhoenixDatabaseMetaData.SYSTEM_CATALOG,
MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0,
Review Comment:
Here MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0 should be increased by 1 and then each
addColumns above will decrease it by 1. This can lead to
BackwardCompatibilityIT tests to fail, which we are seeing,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
