haridsv commented on code in PR #1681:
URL: https://github.com/apache/phoenix/pull/1681#discussion_r1341121209


##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -4107,6 +4109,9 @@ protected PhoenixConnection 
upgradeSystemCatalogIfRequired(PhoenixConnection met
             metaConnection = addColumnsIfNotExists(metaConnection, 
PhoenixDatabaseMetaData.SYSTEM_CATALOG,
                 MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0,

Review Comment:
   The tests are still failing for the same reason, but this time on the 
`PHYSICAL_TABLE_NAME` column (the very first one). Could you please check to 
see what I might have done wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to