[
https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792000#comment-17792000
]
ASF GitHub Bot commented on PHOENIX-6053:
-----------------------------------------
Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411933226
##########
phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java:
##########
@@ -1078,16 +1031,17 @@ public static int getAutoPartitionColIndex(PTable
parentTable) {
return (isMultiTenant && isSalted) ? 2 : (isMultiTenant || isSalted) ?
1 : 0;
}
- public static String getJdbcUrl(RegionCoprocessorEnvironment env) {
- String zkQuorum =
env.getConfiguration().get(HConstants.ZOOKEEPER_QUORUM);
- String zkClientPort =
env.getConfiguration().get(HConstants.ZOOKEEPER_CLIENT_PORT,
- Integer.toString(HConstants.DEFAULT_ZOOKEEPER_CLIENT_PORT));
- String zkParentNode =
env.getConfiguration().get(HConstants.ZOOKEEPER_ZNODE_PARENT,
- HConstants.DEFAULT_ZOOKEEPER_ZNODE_PARENT);
- return PhoenixRuntime.JDBC_PROTOCOL +
PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum
- + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkClientPort
- + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkParentNode;
- }
+ //TODO
Review Comment:
Actually, I think I know what happened here.
This function depends on hbase-server which we don't want in phoenix-core.
So it should be moved somewhere else, but this fn is not used anywhere. So
probably we could just delete it. What do you think?
> Use shaded hadoop-client and hbase-shaded-client in phoenix-client
> ------------------------------------------------------------------
>
> Key: PHOENIX-6053
> URL: https://issues.apache.org/jira/browse/PHOENIX-6053
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Major
> Attachments: Phoenix_separation.pdf
>
>
> The phoenix client is built with the unshaded Hadoop and HBase dependencies,
> and then relocates some (a lot) of those to declutter the client classpath.
> Try to use hadoop-client and hbase-shaded-client-byo-hadoop instead. (And
> keep relocating our direct dependecies)
> While this will likely further bloat the thick client JAR, it shouldÂ
> * clean up the classpath further
> * Would decouple most of the dependencies that Phoenix shares with
> Hbase/Hadoop from them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
