[
https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792004#comment-17792004
]
ASF GitHub Bot commented on PHOENIX-6053:
-----------------------------------------
Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411943717
##########
phoenix-coprocessors/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java:
##########
@@ -210,7 +210,7 @@ public InternalScanner
preCompact(ObserverContext<RegionCoprocessorEnvironment>
InternalScanner s, ScanType scanType, CompactionLifeCycleTracker
tracker,
CompactionRequest request) throws IOException {
- if (!IndexUtil.isLocalIndexStore(store)) { return s; }
Review Comment:
I think Store is defined in hbase-server package, IndexUtil is in
phoenix-core. We want to break (phoenix-core -> hbase-server) dependency so
this function needs to be moved. As its only used in this file, which is indeed
in pheonix-coprocessors (which can use hbase-server), I moved it here.
> Use shaded hadoop-client and hbase-shaded-client in phoenix-client
> ------------------------------------------------------------------
>
> Key: PHOENIX-6053
> URL: https://issues.apache.org/jira/browse/PHOENIX-6053
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Major
> Attachments: Phoenix_separation.pdf
>
>
> The phoenix client is built with the unshaded Hadoop and HBase dependencies,
> and then relocates some (a lot) of those to declutter the client classpath.
> Try to use hadoop-client and hbase-shaded-client-byo-hadoop instead. (And
> keep relocating our direct dependecies)
> While this will likely further bloat the thick client JAR, it shouldÂ
> * clean up the classpath further
> * Would decouple most of the dependencies that Phoenix shares with
> Hbase/Hadoop from them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
