[
https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792082#comment-17792082
]
ASF GitHub Bot commented on PHOENIX-6053:
-----------------------------------------
Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412174495
##########
phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/UncoveredIndexRegionScanner.java:
##########
@@ -321,10 +324,12 @@ private boolean getNextCoveredIndexRow(List<Cell> result)
throws IOException {
}
} else {
if (indexMaintainer.isUncovered()) {
+ long ts = indexRow.get(0).getTimestamp();
// Since we also scan the empty column for uncovered
global indexes, this mean the data row
// does not exist. Delete the index row if the index
is an uncovered global index
- indexMaintainer.deleteRowIfAgedEnough(indexRowKey,
indexRow.get(0).getTimestamp(),
- ageThreshold, false, region);
+ if (indexMaintainer.isAgedEnough(ts, ageThreshold)) {
+
region.delete(indexMaintainer.createDelete(indexRowKey, ts, false));
Review Comment:
I suppose that possibly could differ between implementations, but HRegion
just calls batchMutate in delete if I'm not mistaken.
> Use shaded hadoop-client and hbase-shaded-client in phoenix-client
> ------------------------------------------------------------------
>
> Key: PHOENIX-6053
> URL: https://issues.apache.org/jira/browse/PHOENIX-6053
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Major
> Attachments: Phoenix_separation.pdf
>
>
> The phoenix client is built with the unshaded Hadoop and HBase dependencies,
> and then relocates some (a lot) of those to declutter the client classpath.
> Try to use hadoop-client and hbase-shaded-client-byo-hadoop instead. (And
> keep relocating our direct dependecies)
> While this will likely further bloat the thick client JAR, it shouldÂ
> * clean up the classpath further
> * Would decouple most of the dependencies that Phoenix shares with
> Hbase/Hadoop from them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
